tricore: fixed faulty conditions for extr and imask
authorAndreas Konopik <andreas.konopik@efs-auto.de>
Thu, 11 Feb 2021 11:53:29 +0000 (12:53 +0100)
committerBastian Koppelmann <kbastian@mail.uni-paderborn.de>
Sun, 14 Mar 2021 13:41:56 +0000 (14:41 +0100)
commit9b620609d79ca0e101af024435c5b38b80478969
tree320d7d0f2514f91cc5f4e3a987cd1a12ec4d0a0a
parent4f293079402ad9cd1eae73c256d7adedc0b897b5
tricore: fixed faulty conditions for extr and imask

According to the TC 1.3.1. Architecture Manual [1; page 174], results are
undefined, if pos + width > 32 and not 31 or if width = 0.

We found this error because of a different behavior between qemu-tricore
and the real tricore processor. For pos + width = 32, qemu-tricore did not
generate any intermediate code and ran into a different state compared to
the real hardware.

[1] https://www.infineon.com/dgdl/tc_v131_instructionset_v138.pdf?fileId=db3a304412b407950112b409b6dd0352

[BK: Add the why to the commit message]
Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Signed-off-by: Andreas Konopik <andreas.konopik@efs-auto.de>
Signed-off-by: Georg Hofstetter <georg.hofstetter@efs-auto.de>
Signed-off-by: David Brenken <david.brenken@efs-auto.de>
Message-Id: <20210211115329.8984-2-david.brenken@efs-auto.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
target/tricore/translate.c