firmware: tegra: bpmp: Replace deprecated strncpy() with strscpy_pad()
authorJustin Stitt <justinstitt@google.com>
Wed, 13 Sep 2023 19:38:44 +0000 (19:38 +0000)
committerKees Cook <keescook@chromium.org>
Fri, 29 Sep 2023 21:48:31 +0000 (14:48 -0700)
commit9b9056a3137b2e00273f889bfdf498ef6570e332
tree755493000b289bd276d91f6aadff6bfea1510d90
parentb545465e22f5fec2862132c01a5d2abd3c4c4d50
firmware: tegra: bpmp: Replace deprecated strncpy() with strscpy_pad()

`strncpy` is deprecated for use on NUL-terminated destination strings [1].

We should prefer more robust and less ambiguous string interfaces.

It seems like the filename stored at `namevirt` is expected to be
NUL-terminated.

A suitable replacement is `strscpy_pad` due to the fact that it
guarantees NUL-termination on the destination buffer whilst maintaining
the NUL-padding behavior that strncpy provides.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://github.com/KSPP/linux/issues/90
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230913-strncpy-drivers-firmware-tegra-bpmp-debugfs-c-v1-1-828b0a8914b5@google.com
Signed-off-by: Kees Cook <keescook@chromium.org>
drivers/firmware/tegra/bpmp-debugfs.c