net: ethernet: bcmasp: fix possible OOB write in bcmasp_netfilt_get_all_active()
authorHangyu Hua <hbh25y@gmail.com>
Fri, 8 Sep 2023 06:19:48 +0000 (14:19 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 11 Sep 2023 07:26:10 +0000 (08:26 +0100)
commit9b90aca97f6d5255ca41e716720d138b878cd034
treebbfcf158c663656854fe7c08ebb3616e29bccb88
parentfa60b8163816f194786f3ee334c9a458da7699c6
net: ethernet: bcmasp: fix possible OOB write in bcmasp_netfilt_get_all_active()

rule_locs is allocated in ethtool_get_rxnfc and the size is determined by
rule_cnt from user space. So rule_cnt needs to be check before using
rule_locs to avoid OOB writing or NULL pointer dereference.

Fixes: c5d511c49587 ("net: bcmasp: Add support for wake on net filters")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/asp2/bcmasp.c
drivers/net/ethernet/broadcom/asp2/bcmasp.h
drivers/net/ethernet/broadcom/asp2/bcmasp_ethtool.c