clk: Get runtime PM before walking tree for clk_summary
authorStephen Boyd <sboyd@kernel.org>
Mon, 25 Mar 2024 18:41:59 +0000 (11:41 -0700)
committerStephen Boyd <sboyd@kernel.org>
Mon, 8 Apr 2024 02:31:31 +0000 (19:31 -0700)
commit9d1e795f754db1ac3344528b7af0b17b8146f321
treed8189c34cc8c3974fa1ddae1368167c8fe150973
parente581cf5d216289ef292d1a4036d53ce90e122469
clk: Get runtime PM before walking tree for clk_summary

Similar to the previous commit, we should make sure that all devices are
runtime resumed before printing the clk_summary through debugfs. Failure
to do so would result in a deadlock if the thread is resuming a device
to print clk state and that device is also runtime resuming in another
thread, e.g the screen is turning on and the display driver is starting
up. We remove the calls to clk_pm_runtime_{get,put}() in this path
because they're superfluous now that we know the devices are runtime
resumed. This also squashes a bug where the return value of
clk_pm_runtime_get() wasn't checked, leading to an RPM count underflow
on error paths.

Fixes: 1bb294a7981c ("clk: Enable/Disable runtime PM for clk_summary")
Cc: Taniya Das <quic_tdas@quicinc.com>
Cc: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Link: https://lore.kernel.org/r/20240325184204.745706-6-sboyd@kernel.org
Reviewed-by: Douglas Anderson <dianders@chromium.org>
drivers/clk/clk.c