platform/x86/amd/pmf: Return directly after a failed apmf_if_call() in apmf_sbios_hea...
authorMarkus Elfring <elfring@users.sourceforge.net>
Thu, 28 Dec 2023 08:30:54 +0000 (09:30 +0100)
committerHans de Goede <hdegoede@redhat.com>
Tue, 2 Jan 2024 12:32:14 +0000 (13:32 +0100)
commit9dd3f1ef40d01fdfe69c3ada28b1f201a7207f6e
treeabe19a62dea911fc5dcb3db9b774866725968b33
parent87d8f1ee1d4070571095859d310f6951440f288c
platform/x86/amd/pmf: Return directly after a failed apmf_if_call() in apmf_sbios_heartbeat_notify()

The kfree() function was called in one case by
the apmf_sbios_heartbeat_notify() function during error handling
even if the passed variable contained a null pointer.
This issue was detected by using the Coccinelle software.

* Thus return directly after a call of the function “apmf_if_call” failed
  at the beginning.

* Delete the label “out” which became unnecessary with this refactoring.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Link: https://lore.kernel.org/r/362ee824-fc53-4e19-9529-8b621657635b@web.de
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/amd/pmf/acpi.c