projects / qemu.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 8aa80ff) | patch
etraxfs_eth: correct use of ! and &
authorBlue Swirl <blauwirbel@gmail.com>
Thu, 26 Aug 2010 18:04:18 +0000 (18:04 +0000)
committerBlue Swirl <blauwirbel@gmail.com>
Thu, 26 Aug 2010 18:04:18 +0000 (18:04 +0000)
commit9e84a4708f820976afd825745d4110dbaf58f431
tree52d550312ebadaa1d4f9c50f73a984f201602616tree | snapshot
parent8aa80ff82fb62787cf49e7954e0e6eb4a0429af4commit | diff
etraxfs_eth: correct use of ! and &

Combining bitwise AND and logical NOT is suspicious.

Fixed by this Coccinelle script:
// From http://article.gmane.org/gmane.linux.kernel/646367
@@ expression E1,E2; @@
(
 !E1 & !E2
|
- !E1 & E2
+ !(E1 & E2)
)

Acked-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
hw/etraxfs_eth.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.