f2fs: fix to truncate meta inode pages forcely
authorChao Yu <chao@kernel.org>
Fri, 8 Mar 2024 01:08:34 +0000 (09:08 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Wed, 13 Mar 2024 01:25:17 +0000 (18:25 -0700)
commit9f0c4a46be1fe9b97dbe66d49204c1371e3ece65
tree6b1beff39c187eaeee88bc8d55c46c85519ecf78
parent2f6d721e14b69d6e1251f69fa238b48e8374e25f
f2fs: fix to truncate meta inode pages forcely

Below race case can cause data corruption:

Thread A GC thread
- gc_data_segment
 - ra_data_block
  - locked meta_inode page
- f2fs_inplace_write_data
 - invalidate_mapping_pages
 : fail to invalidate meta_inode page
   due to lock failure or dirty|writeback
   status
 - f2fs_submit_page_bio
 : write last dirty data to old blkaddr
 - move_data_block
  - load old data from meta_inode page
  - f2fs_submit_page_write
  : write old data to new blkaddr

Because invalidate_mapping_pages() will skip invalidating page which
has unclear status including locked, dirty, writeback and so on, so
we need to use truncate_inode_pages_range() instead of
invalidate_mapping_pages() to make sure meta_inode page will be dropped.

Fixes: 6aa58d8ad20a ("f2fs: readahead encrypted block during GC")
Fixes: e3b49ea36802 ("f2fs: invalidate META_MAPPING before IPU/DIO write")
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/checkpoint.c
fs/f2fs/f2fs.h
fs/f2fs/segment.c
include/linux/f2fs_fs.h