media: atomisp-ov2680: Fix ov2680_write_reg() always writing 0 to 16 bit registers
authorHans de Goede <hdegoede@redhat.com>
Sun, 7 Nov 2021 17:15:47 +0000 (17:15 +0000)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 15 Nov 2021 08:11:56 +0000 (08:11 +0000)
commit9f7b638637da7b1785659fd963d79dbca5caaa69
tree9f8c1a3bd6c33fba2f4f0aed2a1260d04343018d
parentbc53e5bdbc7b5044079506990b76b39511ee1582
media: atomisp-ov2680: Fix ov2680_write_reg() always writing 0 to 16 bit registers

The shift << 16 of the value in the code path for 16 bit values is
bogus, put_unaligned_be16() takes the lower 16 bits which will not
always be 0.

This was causing __ov2680_set_exposure() to always set the
OV2680_AGC and OV2680_TIMING_VTS registers to 0.

Link: https://lore.kernel.org/linux-media/20211107171549.267583-10-hdegoede@redhat.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/i2c/atomisp-ov2680.c