um: Add winch to winch_handlers before registering winch IRQ
authorRoberto Sassu <roberto.sassu@huawei.com>
Thu, 7 Mar 2024 10:49:26 +0000 (11:49 +0100)
committerRichard Weinberger <richard@nod.at>
Mon, 22 Apr 2024 20:15:27 +0000 (22:15 +0200)
commita0fbbd36c156b9f7b2276871d499c9943dfe5101
tree9f4d7010b834652070a9d85b03e4ca488effa8f5
parent49ff7d871242d7fd8adb8a2d8347c5d94dda808b
um: Add winch to winch_handlers before registering winch IRQ

Registering a winch IRQ is racy, an interrupt may occur before the winch is
added to the winch_handlers list.

If that happens, register_winch_irq() adds to that list a winch that is
scheduled to be (or has already been) freed, causing a panic later in
winch_cleanup().

Avoid the race by adding the winch to the winch_handlers list before
registering the IRQ, and rolling back if um_request_irq() fails.

Fixes: 42a359e31a0e ("uml: SIGIO support cleanup")
Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Richard Weinberger <richard@nod.at>
arch/um/drivers/line.c