liquidio: replace deprecated strncpy with strscpy
authorJustin Stitt <justinstitt@google.com>
Thu, 5 Oct 2023 21:55:06 +0000 (21:55 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 10 Oct 2023 02:39:29 +0000 (19:39 -0700)
commita16724289af0da1f922e41fd09f229f0beec10f9
tree8c6110242a50eaf6b48297ae924511094fecb4b9
parent092b0be650325b3db490b48182ae23dba0b5755c
liquidio: replace deprecated strncpy with strscpy

`strncpy` is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.

NUL-padding is not required as rep_cfg is memset to 0:
|       memset(&rep_cfg, 0, sizeof(rep_cfg));

A suitable replacement is `strscpy` [2] due to the fact that it
guarantees NUL-termination on the destination buffer without
unnecessarily NUL-padding.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20231005-strncpy-drivers-net-ethernet-cavium-liquidio-lio_vf_rep-c-v1-1-92123a747780@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/cavium/liquidio/lio_vf_rep.c