lwt: Check LWTUNNEL_XMIT_CONTINUE strictly
authorYan Zhai <yan@cloudflare.com>
Fri, 18 Aug 2023 02:58:14 +0000 (19:58 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 18 Aug 2023 14:05:26 +0000 (16:05 +0200)
commita171fbec88a2c730b108c7147ac5e7b2f5a02b47
treec6f4a953627411c1edf0832e135720e7ef5122ed
parent29b22badb7a84b783e3a4fffca16f7768fb31205
lwt: Check LWTUNNEL_XMIT_CONTINUE strictly

LWTUNNEL_XMIT_CONTINUE is implicitly assumed in ip(6)_finish_output2,
such that any positive return value from a xmit hook could cause
unexpected continue behavior, despite that related skb may have been
freed. This could be error-prone for future xmit hook ops. One of the
possible errors is to return statuses of dst_output directly.

To make the code safer, redefine LWTUNNEL_XMIT_CONTINUE value to
distinguish from dst_output statuses and check the continue
condition explicitly.

Fixes: 3a0af8fd61f9 ("bpf: BPF for lightweight tunnel infrastructure")
Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Yan Zhai <yan@cloudflare.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/96b939b85eda00e8df4f7c080f770970a4c5f698.1692326837.git.yan@cloudflare.com
include/net/lwtunnel.h
net/ipv4/ip_output.c
net/ipv6/ip6_output.c