Bluetooth: hci_sock: purge socket queues in the destruct() callback
authorNguyen Dinh Phi <phind.uet@gmail.com>
Thu, 7 Oct 2021 19:04:24 +0000 (03:04 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 12:57:39 +0000 (13:57 +0100)
commita1ddee82de8042bc34275c5116ae6e931a7beff9
treef6962ebcf134833d60bd097c8546f3256e26e395
parent22d0212326570fa059fd2d6e30c6ee09b2fcc79a
Bluetooth: hci_sock: purge socket queues in the destruct() callback

commit 709fca500067524381e28a5f481882930eebac88 upstream.

The receive path may take the socket right before hci_sock_release(),
but it may enqueue the packets to the socket queues after the call to
skb_queue_purge(), therefore the socket can be destroyed without clear
its queues completely.

Moving these skb_queue_purge() to the hci_sock_destruct() will fix this
issue, because nothing is referencing the socket at this point.

Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
Reported-by: syzbot+4c4ffd1e1094dae61035@syzkaller.appspotmail.com
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/bluetooth/hci_sock.c