iomap: Remove large folio handling in iomap_invalidate_folio()
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Fri, 2 Jun 2023 22:09:11 +0000 (18:09 -0400)
committerMatthew Wilcox (Oracle) <willy@infradead.org>
Mon, 24 Jul 2023 22:04:29 +0000 (18:04 -0400)
commita221ab717c43147f728d93513923ba3528f861bf
tree43288a306fe449e45ba24caefb56b4af326d3cec
parent1b0306981e0f1e5a9ad3d08b9c88bfe21b68e3b9
iomap: Remove large folio handling in iomap_invalidate_folio()

We do not need to release the iomap_page in iomap_invalidate_folio()
to allow the folio to be split.  The splitting code will call
->release_folio() if there is still per-fs private data attached to
the folio.  At that point, we will check if the folio is still dirty
and decline to release the iomap_page.  It is possible to trigger the
warning in perfectly legitimate circumstances (eg if a disk read fails,
we do a partial write to the folio, then we truncate the folio), which
will cause those writes to be lost.

Fixes: 60d8231089f0 ("iomap: Support large folios in invalidatepage")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
fs/iomap/buffered-io.c