Revert "drm/i915/mst: Populate connector->ddc"
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 19 Sep 2023 09:56:59 +0000 (12:56 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 21 Sep 2023 11:31:11 +0000 (14:31 +0300)
commita234990f62b86395e7fa358a76bae5a1fc08b80d
treecf30f0c795b22c77c9d3926864dda74cee72bc10
parent7e1ca09667128c661c03aced310d59b99db13bb7
Revert "drm/i915/mst: Populate connector->ddc"

This reverts commit 959fb1a686528df1b8fb0cc7bec8ff851b1594a5.

Looks like the core MST code might not call i2c_adapter() for us
in time, and thus creating the ddc symlink will fail. This will
in fact fail the entire connector registration, but the MST code
doesn't really seem to care about that and blindly plows ahead.
All we may get in the logs is a nearly back to back
register+unregister debug messages:
 [drm:drm_dp_mst_connector_late_register [drm_display_helper]] registering DPMST remote bus for card0-DP-7
 [drm:intel_dp_hpd_pulse [i915]] DPRX ESI: 42 00 00 02
 [drm:drm_dp_mst_connector_early_unregister [drm_display_helper]] unregistering DPMST remote bus for card0-DP-7

Untangling the initialization order may take some real work,
so let's just revert the ddc symlink addition for now...

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9357
Fixes: 959fb1a68652 ("drm/i915/mst: Populate connector->ddc")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230919095659.10742-1-ville.syrjala@linux.intel.com
Acked-by: Jani Nikula <jani.nikula@intel.com>
Tested-by: Karthik B S <karthik.b.s@intel.com>
drivers/gpu/drm/i915/display/intel_dp_mst.c