iommufd: Improve a few unclear bits of code
authorJason Gunthorpe <jgg@nvidia.com>
Wed, 7 Dec 2022 20:44:42 +0000 (16:44 -0400)
committerJason Gunthorpe <jgg@nvidia.com>
Fri, 9 Dec 2022 19:20:37 +0000 (15:20 -0400)
commita26fa392068d1dcdf781397b7a7dd908dd68f030
tree728a1b102e8b808e82cdf331995826f5c948912e
parentc9b8a83a8f2dca9f82288a621595a6a5970cdc5e
iommufd: Improve a few unclear bits of code

Correct a few items noticed late in review:

 - We should assert that the math in batch_clear_carry() doesn't underflow

 - user->locked should be -1 not 0 sicne we just did mmput

 - npages should not have been recalculated, it already has that value

No functional change.

Fixes: 8d160cd4d506 ("iommufd: Algorithms for PFN storage")
Link: https://lore.kernel.org/r/2-v1-0362a1a1c034+98-iommufd_fixes1_jgg@nvidia.com
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Reported-by: Binbin Wu <binbin.wu@linux.intel.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/iommu/iommufd/pages.c