iommu/arm-smmu: Drop if with an always false condition
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 21 Mar 2023 08:41:16 +0000 (09:41 +0100)
committerJoerg Roedel <jroedel@suse.de>
Fri, 31 Mar 2023 08:01:55 +0000 (10:01 +0200)
commita2972cb89935160bfe515b15d28a77694723ac06
treea50218a6fef6a97298e8f62d8bde9874d8c9992e
parente8d018dd0257f744ca50a729e3d042cf2ec9da65
iommu/arm-smmu: Drop if with an always false condition

The remove and shutdown callback are only called after probe completed
successfully. In this case platform_set_drvdata() was called with a
non-NULL argument and so smmu is never NULL. Other functions in this
driver also don't check for smmu being non-NULL before using it.

Also note that returning an error code from a remove callback doesn't
result in the device staying bound. It's still removed and devm allocated
resources are freed (among others *smmu and the register mapping). So
after an early exit to iommu device stayed around and using it probably
oopses.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/20230321084125.337021-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/arm/arm-smmu/arm-smmu.c