irqdomain: Check virq for 0 before use in irq_dispose_mapping()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 5 Apr 2024 19:01:05 +0000 (22:01 +0300)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 8 Apr 2024 10:08:58 +0000 (12:08 +0200)
commita2ea3cd78317ae8995b65b52299158bbae52a77f
treeead075c2dbf487780d934ee92b01ac1d4ad3c8fd
parent7b6f0f278d02de5a8f49202465c6427b56c97545
irqdomain: Check virq for 0 before use in irq_dispose_mapping()

It's a bit hard to read the logic since the virq is used before checking it
for 0. Rearrange the code to make it better to understand.

This, in particular, should clearly answer the question whether the caller
needs to perform this check or not, and there are plenty of places for both
variants, confirming a confusion.

Fun fact that the new code is shorter:

  Function                                     old     new   delta
  irq_dispose_mapping                          278     271      -7
  Total: Before=11625, After=11618, chg -0.06%

when compiled by GCC on Debian for x86_64.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20240405190105.3932034-1-andriy.shevchenko@linux.intel.com
kernel/irq/irqdomain.c