i915/gvt: remove hardcoded value on crc32_start calculation
authorPaulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
Sun, 30 Oct 2022 03:36:28 +0000 (16:36 +1300)
committerZhenyu Wang <zhenyuw@linux.intel.com>
Thu, 17 Nov 2022 06:07:09 +0000 (14:07 +0800)
commita34985dcacdf31892510571c29b38330272c76f4
tree76a23463645bde437971a5edab66f8838ab84e84
parentdf947eb63f16c7e07d3148121757526d5e3bc53b
i915/gvt: remove hardcoded value on crc32_start calculation

struct gvt_firmware_header has a crc32 member in which all members that
come after the that field are used to calculate it. The previous
implementation added the value '4' (crc32's u32 size) to calculate the
crc32_start offset which came across as a bit cryptic until you take a
deeper look at the struct.

This patch changes crc32_start offset to the 'version' member which is
the first member of the struct gvt_firmware_header after crc32.

It's worth mentioning that doing a build before/after this patch results
in no binary output differences.

Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20221030033628.GA279284@mail.google.com
Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
drivers/gpu/drm/i915/gvt/firmware.c