net/x25: Fix to not accept on connected socket
authorHyunwoo Kim <v4bel@theori.io>
Mon, 23 Jan 2023 19:43:23 +0000 (11:43 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Feb 2023 10:26:40 +0000 (11:26 +0100)
commita3967128bc659f72bdf4fe7d2fd20258ea5b5e88
tree2d6afc82d2d2b617ede0762a8cce19b8bdd60479
parent396ea318e7fa6792070ad9e74932b1b61894a934
net/x25: Fix to not accept on connected socket

[ Upstream commit f2b0b5210f67c56a3bcdf92ff665fb285d6e0067 ]

When listen() and accept() are called on an x25 socket
that connect() succeeds, accept() succeeds immediately.
This is because x25_connect() queues the skb to
sk->sk_receive_queue, and x25_accept() dequeues it.

This creates a child socket with the sk of the parent
x25 socket, which can cause confusion.

Fix x25_listen() to return -EINVAL if the socket has
already been successfully connect()ed to avoid this issue.

Signed-off-by: Hyunwoo Kim <v4bel@theori.io>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/x25/af_x25.c