dccp: fix data-race around dp->dccps_mss_cache
authorEric Dumazet <edumazet@google.com>
Thu, 3 Aug 2023 16:30:21 +0000 (16:30 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 5 Aug 2023 01:27:58 +0000 (18:27 -0700)
commita47e598fbd8617967e49d85c49c22f9fc642704c
tree7d9d662e64eb37268b7197729e3cafac5d59bf81
parentfc2ea6ab0a73b58328c61237017e28ba49b3a21e
dccp: fix data-race around dp->dccps_mss_cache

dccp_sendmsg() reads dp->dccps_mss_cache before locking the socket.
Same thing in do_dccp_getsockopt().

Add READ_ONCE()/WRITE_ONCE() annotations,
and change dccp_sendmsg() to check again dccps_mss_cache
after socket is locked.

Fixes: 7c657876b63c ("[DCCP]: Initial implementation")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20230803163021.2958262-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/dccp/output.c
net/dccp/proto.c