platform/x86: ISST: fix use-after-free in tpmi_sst_dev_remove()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Fri, 17 May 2024 14:49:46 +0000 (07:49 -0700)
committerHans de Goede <hdegoede@redhat.com>
Mon, 27 May 2024 09:25:33 +0000 (11:25 +0200)
commita4edf675ba3357f60e2ee310acc15eb9cd5a8ae0
treecb05f9c841fab11a7153a91cbc0432246d226130
parent1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
platform/x86: ISST: fix use-after-free in tpmi_sst_dev_remove()

In tpmi_sst_dev_remove(), tpmi_sst is dereferenced after being freed.
Fix this by reordering the kfree() post the dereference.

Fixes: 9d1d36268f3d ("platform/x86: ISST: Support partitioned systems")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Link: https://lore.kernel.org/r/20240517144946.289615-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c