gpiolib: cdev: annotate struct linereq with __counted_by
authorKees Cook <keescook@chromium.org>
Fri, 22 Sep 2023 17:52:03 +0000 (10:52 -0700)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 25 Sep 2023 07:42:23 +0000 (09:42 +0200)
commita512635da9f7223b97262a5f376c7f1c3e9f6f7d
tree199511367eed9a66098af079d821d766865f9422
parent9f93f18305f5777820491e6ab9b34422c160371b
gpiolib: cdev: annotate struct linereq with __counted_by

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct linereq.
Additionally, since the element count member must be set before accessing
the annotated flexible array member, move its initialization earlier.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpiolib-cdev.c