sfc: use IS_ENABLED() checks for CONFIG_SFC_SRIOV
authorArnd Bergmann <arnd@arndb.de>
Fri, 17 Feb 2023 09:56:39 +0000 (10:56 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 20 Feb 2023 10:49:30 +0000 (10:49 +0000)
commita59f832a71c938779b8abdb022d6d39903e635c3
tree8c2bb62c8cf3091bfa4897119c88493a01ba2cde
parent8173c2f9a1a4a5afcf465a62bc8b616c1fef252d
sfc: use IS_ENABLED() checks for CONFIG_SFC_SRIOV

One local variable has become unused after a recent change:

drivers/net/ethernet/sfc/ef100_nic.c: In function 'ef100_probe_netdev_pf':
drivers/net/ethernet/sfc/ef100_nic.c:1155:21: error: unused variable 'net_dev' [-Werror=unused-variable]
  struct net_device *net_dev = efx->net_dev;
                     ^~~~~~~

The variable is still used in an #ifdef. Replace the #ifdef with
an if(IS_ENABLED()) check that lets the compiler see where it is
used, rather than adding another #ifdef.

This also fixes an uninitialized return value in ef100_probe_netdev_pf()
that gcc did not spot.

Fixes: 7e056e2360d9 ("sfc: obtain device mac address based on firmware handle for ef100")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/ef100_nic.c