projects / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 2a38e6d) | patch
sctp: integer overflow in sctp_auth_create_key()
authorXi Wang <xi.wang@gmail.com>
Tue, 22 Nov 2011 15:55:30 +0000 (15:55 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 29 Nov 2011 05:31:45 +0000 (00:31 -0500)
commita5e5c37434eb182cf50cec90d9736d9a9a390116
tree8b31067a05b221efa900bb333aa58c7fbaffc854tree | snapshot
parent2a38e6d5aed24bb7f0211e0819fac8c32c2b5791commit | diff
sctp: integer overflow in sctp_auth_create_key()

The previous commit 30c2235c is incomplete and cannot prevent integer
overflows. For example, when key_len is 0x80000000 (INT_MAX + 1), the
left-hand side of the check, (INT_MAX - key_len), which is unsigned,
becomes 0xffffffff (UINT_MAX) and bypasses the check.

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
ep93xx device tree rework repo: git://git.maquefel.me/linux.git