qapi: Simplify how qmp_dispatch() gets the request ID
authorMarkus Armbruster <armbru@redhat.com>
Tue, 17 Mar 2020 11:54:48 +0000 (12:54 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Tue, 17 Mar 2020 20:25:47 +0000 (21:25 +0100)
commita62c61747fc0934e0f42a37aa078a21c50565fe6
tree5482fc7a2af10a0535045b75e80530d529c070cb
parentd3226035630c6f0805ed26c77011e49565029cb0
qapi: Simplify how qmp_dispatch() gets the request ID

We convert the request object to a QDict twice: first in
qmp_dispatch() to get the request ID, and then again in
qmp_dispatch_check_obj(), which converts to QDict, then checks and
returns it.  We can't get the request ID from the latter, because it's
null when the qdict flunks the checks.

Move the checked conversion to QDict from qmp_dispatch_check_obj() to
qmp_dispatch(), and drop the duplicate there.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20200317115459.31821-24-armbru@redhat.com>
qapi/qmp-dispatch.c