drm/lima: fix shared irq handling on driver remove
authorErico Nunes <nunes.erico@gmail.com>
Mon, 1 Apr 2024 22:43:28 +0000 (00:43 +0200)
committerQiang Yu <yuq825@gmail.com>
Mon, 15 Apr 2024 01:06:18 +0000 (09:06 +0800)
commita6683c690bbfd1f371510cb051e8fa49507f3f5e
treeadb26c314c2aba49d0f1834f409bbd694ece475f
parenta421cc7a6a001b70415aa4f66024fa6178885a14
drm/lima: fix shared irq handling on driver remove

lima uses a shared interrupt, so the interrupt handlers must be prepared
to be called at any time. At driver removal time, the clocks are
disabled early and the interrupts stay registered until the very end of
the remove process due to the devm usage.
This is potentially a bug as the interrupts access device registers
which assumes clocks are enabled. A crash can be triggered by removing
the driver in a kernel with CONFIG_DEBUG_SHIRQ enabled.
This patch frees the interrupts at each lima device finishing callback
so that the handlers are already unregistered by the time we fully
disable clocks.

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240401224329.1228468-2-nunes.erico@gmail.com
drivers/gpu/drm/lima/lima_gp.c
drivers/gpu/drm/lima/lima_mmu.c
drivers/gpu/drm/lima/lima_pp.c