hw/pci: Use -1 as the default value for rombar
authorAkihiko Odaki <akihiko.odaki@daynix.com>
Mon, 12 Feb 2024 10:20:29 +0000 (19:20 +0900)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Thu, 9 Jan 2025 17:16:18 +0000 (18:16 +0100)
commita7a3784128fa1de275b5eb2406f3f46842fdbd1a
tree9afb144ff6d07480e81743527dcf981e8ec47d8a
parent3f8bcbba3b320c610689576fc47595f1076198dd
hw/pci: Use -1 as the default value for rombar

vfio_pci_size_rom() distinguishes whether rombar is explicitly set to 1
by checking dev->opts, bypassing the QOM property infrastructure.

Use -1 as the default value for rombar to tell if the user explicitly
set it to 1. The property is also converted from unsigned to signed.
-1 is signed so it is safe to give it a new meaning. The values in
[2 ^ 31, 2 ^ 32) become invalid, but nobody should have typed these
values by chance.

Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20250104-reuse-v18-13-c349eafd8673@daynix.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
hw/pci/pci.c
hw/vfio/pci.c
include/hw/pci/pci_device.h