drm/xe: Prefer struct_size over open coded arithmetic
authorErick Archer <erick.archer@gmx.com>
Sat, 10 Feb 2024 14:19:12 +0000 (15:19 +0100)
committerLucas De Marchi <lucas.demarchi@intel.com>
Fri, 23 Feb 2024 04:58:20 +0000 (20:58 -0800)
commita7a3d73686f5837916ebffda77afa4343754e7dc
tree2e1f68c96212ecd86d4f62f0c21842a6c6db2bc9
parent7a975748d4dc0a524c99a390c6f74b7097ef8cf7
drm/xe: Prefer struct_size over open coded arithmetic

This is an effort to get rid of all multiplications from allocation
functions in order to prevent integer overflows [1].

As the "q" variable is a pointer to "struct xe_exec_queue" and this
structure ends in a flexible array:

struct xe_exec_queue {
[...]
struct xe_lrc lrc[];
};

the preferred way in the kernel is to use the struct_size() helper to
do the arithmetic instead of the argument "size + size * count" in the
kzalloc() function.

This way, the code is more readable and more safer.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
Link: https://github.com/KSPP/linux/issues/160
Signed-off-by: Erick Archer <erick.archer@gmx.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240210141913.6611-1-erick.archer@gmx.com
drivers/gpu/drm/xe/xe_exec_queue.c