power: supply: bq25890: Ensure pump_express_work is cancelled on remove
authorHans de Goede <hdegoede@redhat.com>
Mon, 28 Nov 2022 09:28:48 +0000 (10:28 +0100)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Sat, 3 Dec 2022 02:06:51 +0000 (03:06 +0100)
commita7aaa80098d5b7608b2dc1e883e3c3f929415243
tree5d1906952989cc7eced122a1caa838a168fb8fad
parent54c03bfd094fb74f9533a9c28250219afe182382
power: supply: bq25890: Ensure pump_express_work is cancelled on remove

The pump_express_work which gets queued from an external_power_changed
callback might be pending / running on remove() (or on probe failure).

Add a devm action cancelling the work, to ensure that it is cancelled.

Note the devm action is added before devm_power_supply_register(), making
it run after devm unregisters the power_supply, so that the work cannot
be queued anymore (this is also why a devm action is used for this).

Fixes: 48f45b094dbb ("power: supply: bq25890: Support higher charging voltages through Pump Express+ protocol")
Reviewed-by: Marek Vasut <marex@denx.de>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/bq25890_charger.c