ARM: findbit: fix overflowing offset
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Tue, 26 Jul 2022 22:51:48 +0000 (23:51 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:23:05 +0000 (14:23 +0200)
commita7c16b8966d479909057e7f9f1e865d9dd987ac4
tree23f6db7f3977bdca7f2d43898cbb64cb37cc4716
parent0ff7f81559faac081d14b8f2a243f3114a54f73c
ARM: findbit: fix overflowing offset

[ Upstream commit ec85bd369fd2bfaed6f45dd678706429d4f75b48 ]

When offset is larger than the size of the bit array, we should not
attempt to access the array as we can perform an access beyond the
end of the array. Fix this by changing the pre-condition.

Using "cmp r2, r1; bhs ..." covers us for the size == 0 case, since
this will always take the branch when r1 is zero, irrespective of
the value of r2. This means we can fix this bug without adding any
additional code!

Tested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm/lib/findbit.S