accel/habanalabs: fix information leak in sec_attest_info()
authorXingyuan Mo <hdthky0@gmail.com>
Fri, 8 Dec 2023 13:00:59 +0000 (21:00 +0800)
committerOded Gabbay <ogabbay@kernel.org>
Tue, 19 Dec 2023 09:09:44 +0000 (11:09 +0200)
commita9f07790a4b2250f0140e9a61c7f842fd9b618c7
tree9e35c9895056311508f4e8ea75d170472acfcdbb
parentbc5f15abcf95ce7e4c2e33daddcb5850ee5e671d
accel/habanalabs: fix information leak in sec_attest_info()

This function may copy the pad0 field of struct hl_info_sec_attest to user
mode which has not been initialized, resulting in leakage of kernel heap
data to user mode. To prevent this, use kzalloc() to allocate and zero out
the buffer, which can also eliminate other uninitialized holes, if any.

Fixes: 0c88760f8f5e ("habanalabs/gaudi2: add secured attestation info uapi")
Signed-off-by: Xingyuan Mo <hdthky0@gmail.com>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/accel/habanalabs/common/habanalabs_ioctl.c