stmmac: intel: Fix kernel crash due to wrong error path
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 29 Apr 2020 15:09:32 +0000 (18:09 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 May 2020 04:00:17 +0000 (21:00 -0700)
commitab1c637cc6d80c0ee1d5d15f7ec8977f49feee75
treefe5c2c4eecc3874e50090d91cef04d81e33681fd
parent6ef4889fc0b3aa6ab928e7565935ac6f762cee6e
stmmac: intel: Fix kernel crash due to wrong error path

Unfortunately sometimes ->probe() may fail. The commit b9663b7ca6ff
("net: stmmac: Enable SERDES power up/down sequence")
messed up with error handling and thus:

[   12.811311] ------------[ cut here ]------------
[   12.811993] kernel BUG at net/core/dev.c:9937!

Fix this by properly crafted error path.

Fixes: b9663b7ca6ff ("net: stmmac: Enable SERDES power up/down sequence")
Cc: Voon Weifeng <weifeng.voon@intel.com>
Cc: Ong Boon Leong <boon.leong.ong@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c