backlight: mp3309c: Fix uninitialized local variable
authorFlavio Suligoi <f.suligoi@asem.it>
Wed, 29 Nov 2023 16:45:14 +0000 (17:45 +0100)
committerLee Jones <lee@kernel.org>
Fri, 1 Dec 2023 11:24:21 +0000 (11:24 +0000)
commitab47505ce45b869ab649024dc932e981fcdd6e5f
tree7f5317ce33e37099cd9e9ed932d8cf55a844677b
parent58793f263abc8e5233fabf7466219202db09d048
backlight: mp3309c: Fix uninitialized local variable

In the function "pm3309c_parse_dt_node", when the dimming analog control
mode (by I2C messages) is enabled, the local variable "prop_levels" is
tested without any initialization, as indicated by the following smatch
warning:

drivers/video/backlight/mp3309c.c:279 pm3309c_parse_dt_node() error: uninitialized symbol 'prop_levels'.

To avoid any problem in case of undefined behavior, we need to initialize
it to "NULL".

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/dri-devel/af0a1870-693b-442f-9b11-0503cfcd944a@moroto.mountain/
Fixes: 2e914516a58c ("backlight: mp3309c: Add support for MPS MP3309C")
Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Link: https://lore.kernel.org/r/20231129164514.2772719-1-f.suligoi@asem.it
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/video/backlight/mp3309c.c