cifs/smb3: Fix data inconsistent when punch hole
authorZhang Xiaoxu <zhangxiaoxu5@huawei.com>
Tue, 23 Jun 2020 11:31:53 +0000 (07:31 -0400)
committerSteve French <stfrench@microsoft.com>
Wed, 24 Jun 2020 00:06:27 +0000 (19:06 -0500)
commitacc91c2d8de4ef46ed751c5f9df99ed9a109b100
treeb8a23966d42193f236b1b89a17180187299cc4cb
parent6b69040247e14b43419a520f841f2b3052833df9
cifs/smb3: Fix data inconsistent when punch hole

When punch hole success, we also can read old data from file:
  # strace -e trace=pread64,fallocate xfs_io -f -c "pread 20 40" \
           -c "fpunch 20 40" -c"pread 20 40" file
  pread64(3, " version 5.8.0-rc1+"..., 40, 20) = 40
  fallocate(3, FALLOC_FL_KEEP_SIZE|FALLOC_FL_PUNCH_HOLE, 20, 40) = 0
  pread64(3, " version 5.8.0-rc1+"..., 40, 20) = 40

CIFS implements the fallocate(FALLOCATE_FL_PUNCH_HOLE) with send SMB
ioctl(FSCTL_SET_ZERO_DATA) to server. It just set the range of the
remote file to zero, but local page caches not updated, then the
local page caches inconsistent with server.

Also can be found by xfstests generic/316.

So, we need to remove the page caches before send the SMB
ioctl(FSCTL_SET_ZERO_DATA) to server.

Fixes: 31742c5a33176 ("enable fallocate punch hole ("fallocate -p") for SMB3")
Suggested-by: Pavel Shilovsky <pshilov@microsoft.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Cc: stable@vger.kernel.org # v3.17
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/smb2ops.c