python/qmp: remove Server.wait_closed() call for Python 3.12
authorJohn Snow <jsnow@redhat.com>
Fri, 6 Oct 2023 19:52:41 +0000 (15:52 -0400)
committerJohn Snow <jsnow@redhat.com>
Wed, 11 Oct 2023 20:02:34 +0000 (16:02 -0400)
commitacf873873ae38e68371b0c53c42d3530636ff94e
tree15b7c98fc3d452f6746a6a206660ddbb7b18330d
parentff2e08132f332b6b64d69774dd9a40a2b74fd04c
python/qmp: remove Server.wait_closed() call for Python 3.12

This patch is a backport from
https://gitlab.com/qemu-project/python-qemu-qmp/-/commit/e03a3334b6a477beb09b293708632f2c06fe9f61

According to Guido in https://github.com/python/cpython/issues/104344 ,
this call was never meant to wait for the server to shut down - that is
handled synchronously - but instead, this waits for all connections to
close. Or, it would have, if it wasn't broken since it was introduced.

3.12 fixes the bug, which now causes a hang in our code. The fix is just
to remove the wait.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-id: 20231006195243.3131140-3-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
python/qemu/qmp/protocol.py