scsi: elx: efct: Fix pointer error checking in debugfs init
authorJames Smart <jsmart2021@gmail.com>
Fri, 18 Jun 2021 23:30:04 +0000 (16:30 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 19 Jun 2021 03:01:04 +0000 (23:01 -0400)
commitae3272ec5e9772de143b6326b2c3a61529786ddd
treead973f25c892b6ce158b28d7fc310a28729ff274
parentca7f33c6b4a9b9893a5ba3aac57e7255510a4aac
scsi: elx: efct: Fix pointer error checking in debugfs init

debugfs_create_xxx routines, which return pointers, are being checked for
error by looking for NULL values. The routines may return pointer-munged
-Exxx codes, so they should be using IS_ERR() to adapt.

There are two cases:

 - The first case is on initial directory creation, which actually doesn't
   need to be checked. So remove the check.

 - Creation of the sessions subdirectory. Modify this creation to create
   under the initial directory created, and fix failure check.

Link: https://lore.kernel.org/r/20210618233004.83769-1-jsmart2021@gmail.com
Fixes: 4df84e846624 ("scsi: elx: efct: Driver initialization routines")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/elx/efct/efct_xport.c