ipmi: refactor deprecated strncpy
authorJustin Stitt <justinstitt@google.com>
Wed, 13 Sep 2023 17:13:04 +0000 (17:13 +0000)
committerCorey Minyard <minyard@acm.org>
Wed, 13 Sep 2023 17:55:11 +0000 (12:55 -0500)
commitb00839ca4cca8aa9641c121c848a553d6220ce70
tree58a37095c9ccf41799e3d9880cccc8eec73644fb
parent3669558bdf354cd352be955ef2764cde6a9bf5ec
ipmi: refactor deprecated strncpy

`strncpy` is deprecated for use on NUL-terminated destination strings [1].

In this case, strncpy is being used specifically for its NUL-padding
behavior (and has been commented as such). Moreover, the destination
string is not required to be NUL-terminated [2].

We can use a more robust and less ambiguous interface in
`memcpy_and_pad` which makes the code more readable and even eliminates
the need for that comment.

Let's also use `strnlen` instead of `strlen()` with an upper-bounds
check as this is intrinsically a part of `strnlen`.

Also included in this patch is a simple 1:1 change of `strncpy` to
`strscpy` for ipmi_ssif.c. If NUL-padding is wanted here as well then we
should opt again for `strscpy_pad`.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://lore.kernel.org/all/ZQEADYBl0uZ1nX60@mail.minyard.net/
Link: https://github.com/KSPP/linux/issues/90
Cc: linux-hardening@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Justin Stitt <justinstitt@google.com>
Message-Id: <20230913-strncpy-drivers-char-ipmi-ipmi-v2-1-e3bc0f6e599f@google.com>
Signed-off-by: Corey Minyard <minyard@acm.org>
drivers/char/ipmi/ipmi_msghandler.c
drivers/char/ipmi/ipmi_ssif.c