ui: remove break after g_assert_not_reached()
authorPierrick Bouvier <pierrick.bouvier@linaro.org>
Tue, 10 Sep 2024 22:16:03 +0000 (15:16 -0700)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Fri, 13 Sep 2024 18:12:16 +0000 (20:12 +0200)
commitb3372e0ec818d7747963a2ec7ae04fd1a8152afd
treebf509d8851ca00ba6787a53edf5fac3e1ff5b071
parentae23cd00170baaa2777eb1ee87b70f472dbb3c44
ui: remove break after g_assert_not_reached()

Use of assert(false) can trip spurious control flow warnings from
some versions of GCC (i.e. using -fsanitize=thread with gcc-12):

  error: control reaches end of non-void function [-Werror=return-type]
        default:
            g_assert_not_reached();
            break;
          | ^^^^^

Solve that by removing the unreachable 'break' statement, unifying
the code base on g_assert_not_reached() instead.

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240910221606.1817478-37-pierrick.bouvier@linaro.org>
[PMD: Add description suggested by Eric Blake]
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
ui/qemu-pixman.c