drm/imagination: Fixed infinite loop in pvr_vm_mips_map()
authorDonald Robson <donald.robson@imgtec.com>
Fri, 8 Dec 2023 16:08:25 +0000 (16:08 +0000)
committerMaxime Ripard <mripard@kernel.org>
Fri, 15 Dec 2023 13:03:57 +0000 (14:03 +0100)
commitb39610c773431ac7991cf6235e26d693ccabd9e9
tree02ebe33ce06ca2a529a1b0e20c0594835036625a
parentb1a2aa9bcbb88a7dc1c4df98dbf4f4df9ca79c9f
drm/imagination: Fixed infinite loop in pvr_vm_mips_map()

Unwinding loop in error path for this function uses unsigned limit
variable, causing the promotion of the signed counter variable.

--> 204         for (; pfn >= start_pfn; pfn--)
                       ^^^^^^^^^^^^^^^^
If start_pfn can be zero then this is an endless loop.  I've seen this
code in other places as well.  This loop is slightly off as well.  It
should decrement pfn on the first iteration.

Fix by making the loop limit variables signed. Also fix missing
predecrement by modifying to while loop.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Donald Robson <donald.robson@imgtec.com>
Signed-off-by: Maxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20231208160825.92933-1-donald.robson@imgtec.com
drivers/gpu/drm/imagination/pvr_vm_mips.c