soundwire: bus: don't clear SDCA_CASCADE bit
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 26 Mar 2024 06:00:21 +0000 (06:00 +0000)
committerVinod Koul <vkoul@kernel.org>
Thu, 28 Mar 2024 18:14:04 +0000 (23:44 +0530)
commitb3a6809e623c03371ba51845129cdec3ebb7896e
tree6ffaa3aed998421501d495c184c2e759b4a11d39
parente05af1a42bb804e0465f76baa79a1ae8e4b619fc
soundwire: bus: don't clear SDCA_CASCADE bit

The SDCA_CASCADE bit is a SoundWire 1.2 addition. It is technically in
the DP0_INT register, but SDCA interrupts shall not be handled as part
of the DP0 interrupt processing.

The existing code has clear comments that we don't want to touch the
SDCA_CASCADE bit, but it's actually cleared due to faulty logic dating
from SoundWire 1.0

In theory clearing this bit should have no effect: a cascade bit
remains set while all ORed status are set, but better safe than sorry.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Chao Song <chao.song@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20240326060021.973501-1-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/bus.c