hw/scsi/scsi-disk: MODE_PAGE_ALLS not allowed in MODE SELECT commands
authorMauro Matteo Cascella <mcascell@redhat.com>
Thu, 4 Nov 2021 16:31:38 +0000 (17:31 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 8 Nov 2021 07:55:29 +0000 (08:55 +0100)
commitb3af7fdf9cc537f8f0dd3e2423d83f5c99a457e8
treea9f092aaf21a75e1d4cb9945719bb2456e0057f0
parentb04dc92e013d55c9ac8082caefff45dcfb1310e7
hw/scsi/scsi-disk: MODE_PAGE_ALLS not allowed in MODE SELECT commands

This avoids an off-by-one read of 'mode_sense_valid' buffer in
hw/scsi/scsi-disk.c:mode_sense_page().

Fixes: CVE-2021-3930
Cc: qemu-stable@nongnu.org
Reported-by: Alexander Bulekov <alxndr@bu.edu>
Fixes: a8f4bbe2900 ("scsi-disk: store valid mode pages in a table")
Fixes: #546
Reported-by: Qiuhao Li <Qiuhao.Li@outlook.com>
Signed-off-by: Mauro Matteo Cascella <mcascell@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/scsi/scsi-disk.c