fanotify: Make waits for fanotify events only killable
authorJan Kara <jack@suse.cz>
Thu, 21 Feb 2019 10:47:23 +0000 (11:47 +0100)
committerJan Kara <jack@suse.cz>
Thu, 21 Feb 2019 10:47:23 +0000 (11:47 +0100)
commitb51905798195eeb427c873643b3ada0d7bd991a7
treea97c478964268f29f50ae0e2a98f36d22861aa05
parentfabf7f29b3e2ce5ed9741bf06f3583cd7e82ed1c
fanotify: Make waits for fanotify events only killable

Making waits for response to fanotify permission events interruptible
can result in EINTR returns from open(2) or other syscalls when there's
e.g. AV software that's monitoring the file. Orion reports that e.g.
bash is complaining like:

bash: /etc/bash_completion.d/itweb-settings.bash: Interrupted system call

So for now convert the wait from interruptible to only killable one.
That is mostly invisible to userspace. Sadly this breaks hibernation
with fanotify permission events pending again but we have to put more
thought into how to fix this without regressing userspace visible
behavior.

Reported-by: Orion Poplawski <orion@nwra.com>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/notify/fanotify/fanotify.c