projects / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 6647b33) | patch
netlink: hold nlk->cb_mutex longer in __netlink_dump_start()
authorEric Dumazet <edumazet@google.com>
Thu, 22 Feb 2024 10:50:13 +0000 (10:50 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 26 Feb 2024 11:46:12 +0000 (11:46 +0000)
commitb5590270068c4324dac4a2b5a4a156e02e21339f
tree6812e51f0cb993f8debdc4b48dd165850b9b4658tree | snapshot
parent6647b338fc5c6741736fe51a25fc2c0bec6398b8commit | diff
netlink: hold nlk->cb_mutex longer in __netlink_dump_start()

__netlink_dump_start() releases nlk->cb_mutex right before
calling netlink_dump() which grabs it again.

This seems dangerous, even if KASAN did not bother yet.

Add a @lock_taken parameter to netlink_dump() to let it
grab the mutex if called from netlink_recvmsg() only.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netlink/af_netlink.c diff | blob | history
ep93xx device tree rework repo: git://git.maquefel.me/linux.git