selftests/bpf: Fix erroneous bitmask operation
authorJeroen van Ingen Schenau <jeroen.vaningenschenau@novoserve.com>
Thu, 30 Nov 2023 12:03:53 +0000 (13:03 +0100)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 1 Dec 2023 15:12:45 +0000 (16:12 +0100)
commitb6a3451e0847d5d70fb5fa2b2a80ab9f80bf2c7b
tree49e0a5f9345088f240b5bff686f8978b4589e8fe
parent15bc81212f593fbd7bda787598418b931842dc14
selftests/bpf: Fix erroneous bitmask operation

xdp_synproxy_kern.c is a BPF program that generates SYN cookies on
allowed TCP ports and sends SYNACKs to clients, accelerating synproxy
iptables module.

Fix the bitmask operation when checking the status of an existing
conntrack entry within tcp_lookup() function. Do not AND with the bit
position number, but with the bitmask value to check whether the entry
found has the IPS_CONFIRMED flag set.

Fixes: fb5cd0ce70d4 ("selftests/bpf: Add selftests for raw syncookie helpers")
Signed-off-by: Jeroen van Ingen Schenau <jeroen.vaningenschenau@novoserve.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Tested-by: Minh Le Hoang <minh.lehoang@novoserve.com>
Link: https://lore.kernel.org/xdp-newbies/CAAi1gX7owA+Tcxq-titC-h-KPM7Ri-6ZhTNMhrnPq5gmYYwKow@mail.gmail.com/T/#u
Link: https://lore.kernel.org/bpf/20231130120353.3084-1-jeroen.vaningenschenau@novoserve.com
tools/testing/selftests/bpf/progs/xdp_synproxy_kern.c