scsi: fix allocation for s390x loadparm
authorPaolo Bonzini <pbonzini@redhat.com>
Tue, 19 Nov 2024 21:31:22 +0000 (22:31 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 20 Nov 2024 00:29:29 +0000 (01:29 +0100)
commitb73d7eff1eedb2399cd594bc872d5db13506d951
tree396c6bbe97f192328f45043c5a946e6984cd92d1
parent37ee17eebb93eb485fc122452a4c7e9202a8b449
scsi: fix allocation for s390x loadparm

Coverity reports a possible buffer overrun due to a non-NUL-terminated
string in scsi_property_set_loadparm().  While things are not so easy,
because qdev_prop_sanitize_s390x_loadparm is designed to operate on a
buffer that is not NUL-terminated, in this case the string *does* have
to be NUL-terminated because it is read by scsi_property_get_loadparm
and s390_build_iplb.

Reviewed-by: jrossi@linux.ibm.com
Cc: thuth@redhat.com
Fixes: 429442e52d9 ("hw: Add "loadparm" property to scsi disk devices for booting on s390x", 2024-11-18)
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/scsi/scsi-disk.c