dm writecache: fix smatch warning about invalid return from writecache_map
authorMikulas Patocka <mpatocka@redhat.com>
Mon, 8 Aug 2022 14:50:10 +0000 (10:50 -0400)
committerMike Snitzer <snitzer@kernel.org>
Tue, 9 Aug 2022 23:20:23 +0000 (19:20 -0400)
commitb7f362d6413ebd0167ac5a9f09ad5dca5490ac1a
tree60fcf0216b21e3d3d08e9f66fcced5f08413e645
parentf876df9f12cda68e68995b33b36491d78fd3ecce
dm writecache: fix smatch warning about invalid return from writecache_map

There's a smatch warning "inconsistent returns '&wc->lock'" in
dm-writecache. The reason for the warning is that writecache_map()
doesn't drop the lock on the impossible path.

Fix this warning by adding wc_unlock() after the BUG statement (so
that it will be compiled-away anyway).

Fixes: df699cc16ea5e ("dm writecache: report invalid return from writecache_map helpers")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
drivers/md/dm-writecache.c