backends/vhost-user.c: prevent using uninitialized vqs
authorRaphael Norwitz <raphael.norwitz@nutanix.com>
Thu, 22 Aug 2019 18:34:25 +0000 (11:34 -0700)
committerMichael S. Tsirkin <mst@redhat.com>
Mon, 16 Sep 2019 10:27:35 +0000 (06:27 -0400)
commitb8487a357855e78957d8c9bddbbcf58548e1aa51
tree3f2766084746913848098f68528eddba7f83091d
parentd8438bd24a3f2b6fd6d0e788c18483ca9e239b36
backends/vhost-user.c: prevent using uninitialized vqs

Similar rational to: e6cc11d64fc998c11a4dfcde8fda3fc33a74d844

For vhost scsi and vhost-user-scsi an issue was observed
where, of the 3 virtqueues, seabios would only set cmd,
leaving ctrl and event without a physical address.
This can caused vhost_verify_ring_part_mapping to return
ENOMEM, causing the following logs:

qemu-system-x86_64: Unable to map available ring for ring 0
qemu-system-x86_64: Verify ring failure on region 0

The issue has already been fixed elsewhere, but it was noted
that in backends/vhost-user.c, the vhost_user_backend_dev_init()
function, which other vdevs use in their realize() to initialize
their vqs, was not being properly zeroing out the queues. This
commit ensures hardware modules using the
vhost_user_backend_dev_init() API properly zero out their vqs on
initialization.

Suggested-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
Message-Id: <1566498865-55506-2-git-send-email-raphael.norwitz@nutanix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
backends/vhost-user.c