file-posix: Include filename in locking error message
authorFam Zheng <famz@redhat.com>
Tue, 25 Sep 2018 05:05:01 +0000 (13:05 +0800)
committerKevin Wolf <kwolf@redhat.com>
Mon, 1 Oct 2018 10:51:11 +0000 (12:51 +0200)
commitb857431d2abe3945b672b41f33690e9943a8752a
tree77204d85a5c584bc6cd3b014b479af90f390a0ba
parent07f426c35eddd79388a23d11cb278600d7e3831d
file-posix: Include filename in locking error message

Image locking errors happening at device initialization time doesn't say
which file cannot be locked, for instance,

    -device scsi-disk,drive=drive-1: Failed to get shared "write" lock
    Is another process using the image?

could refer to either the overlay image or its backing image.

Hoist the error_append_hint to the caller of raw_check_lock_bytes where
file name is known, and include it in the error hint.

Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/file-posix.c
tests/qemu-iotests/153.out
tests/qemu-iotests/182.out