tty: pty: Fix race condition between release_one_tty and pty_write
authorSahara <keun-o.park@darkmatter.ae>
Mon, 11 Feb 2019 07:09:15 +0000 (11:09 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Mar 2019 16:28:23 +0000 (01:28 +0900)
commitb9ca5f8560af244489b4a1bc1ae88b341f24bc95
tree2fa81b283d5ff446fe29cf26aea8b6c05db22479
parent75ddbc1fb11efac87b611d48e9802f6fe2bb2163
tty: pty: Fix race condition between release_one_tty and pty_write

Especially when a linked tty is used such as pty, the linked tty
port's buf works have not been cancelled while master tty port's
buf work has been cancelled. Since release_one_tty and flush_to_ldisc
run in workqueue threads separately, when pty_cleanup happens and
link tty port is freed, flush_to_ldisc tries to access freed port
and port->itty, eventually it causes a panic.
This patch utilizes the magic value with holding the tty_mutex to
check if the tty->link is valid.

Fixes: 2b022ab7542d ("pty: cancel pty slave port buf's work in tty_release")
Signed-off-by: Sahara <keun-o.park@darkmatter.ae>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/pty.c
drivers/tty/tty_io.c