Input: keyspan-remote - fix control-message timeouts
authorJohan Hovold <johan@kernel.org>
Mon, 13 Jan 2020 18:38:57 +0000 (10:38 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 17 Jan 2020 04:26:45 +0000 (20:26 -0800)
commitba9a103f40fc4a3ec7558ec9b0b97d4f92034249
tree2761aee2921aaeeb76596432a193ef6b608d7be5
parentce535a2efb48d8d4c4e4b97e2764d7cee73d9b55
Input: keyspan-remote - fix control-message timeouts

The driver was issuing synchronous uninterruptible control requests
without using a timeout. This could lead to the driver hanging on probe
due to a malfunctioning (or malicious) device until the device is
physically disconnected. While sleeping in probe the driver prevents
other devices connected to the same hub from being added to (or removed
from) the bus.

The USB upper limit of five seconds per request should be more than
enough.

Fixes: 99f83c9c9ac9 ("[PATCH] USB: add driver for Keyspan Digital Remote")
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable <stable@vger.kernel.org> # 2.6.13
Link: https://lore.kernel.org/r/20200113171715.30621-1-johan@kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/keyspan_remote.c